Properly handle metrics feature being disabled

n0-computer · Oct 7, 2024 · 4a379b9 · 4a379b9
1 parent 1bf80d1
commit 4a379b9
Showing 1 changed file with 24 additions and 16 deletions.
diff --git a/iroh/src/node/builder.rs b/iroh/src/node/builder.rs
@@ -697,26 +697,34 @@ where
         let client = crate::client::Iroh::new(quic_rpc::RpcClient::new(controller.clone()));
 
         let metrics_exporter_handle = if let Some(config) = self.metrics_push_config {
-            let PushMetricsConfig {
-                interval,
-                endpoint: gateway_endpoint,
-                service_name,
-                instance_name,
-                username,
-                password,
-            } = config;
-            let handle = tokio::spawn(async move {
-                iroh_metrics::service::exporter(
-                    gateway_endpoint,
+            #[cfg(feature = "metrics")]
+            {
+                let PushMetricsConfig {
+                    interval,
+                    endpoint: gateway_endpoint,
                     service_name,
                     instance_name,
                     username,
                     password,
-                    interval,
-                )
-                .await
-            });
-            Some(AbortOnDropHandle::new(handle))
+                } = config;
+                let handle = tokio::spawn(async move {
+                    iroh_metrics::service::exporter(
+                        gateway_endpoint,
+                        service_name,
+                        instance_name,
+                        username,
+                        password,
+                        interval,
+                    )
+                    .await
+                });
+                Some(AbortOnDropHandle::new(handle))
+            }
+            #[cfg(not(feature = "metrics"))]
+            {
+                warn!("Metrics push configuration provided, but metrics feature is not enabled. Ignoring.");
+                None
+            }
         } else {
             None
         };