Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #32

Merged
merged 15 commits into from
Jan 30, 2024
Merged

Development #32

merged 15 commits into from
Jan 30, 2024

Conversation

n1crack
Copy link
Owner

@n1crack n1crack commented Jan 23, 2024

  • add select event to main library, so we can get the selected items outside of the library.
  • add fr language
  • add fade transition to modals
  • move language selector to about/settings page

@DreamlandOwO
Copy link
Contributor

DreamlandOwO commented Jan 24, 2024

I think we should fix our api to close #11, really should use correct method (or at least use POST instead of GET do idempotent
stuff, I think I still can change current php backend, what you think?

Also for frontend I suggest we can add a request transformer (already in my fork, but I need more polish), let user change request params, headers to close #9, so would be easy intergation for custom backend implementation.

@DreamlandOwO
Copy link
Contributor

Do you have discord? It would be faster if we can create a group just discuss like some specfic implentation or just general stuff instead of use github back and forth

@n1crack
Copy link
Owner Author

n1crack commented Jan 24, 2024

I think we can already send additional data with postData props, havent use it for a while but it should work.

like :
post-data="{abc : 123}"

about #11, yes you are right, we should. I'm busy at the moment, I'll look at these when I have free time. Ofc, I would be happy if you help :)

discord name n1crack, you can add me

@n1crack n1crack merged commit 1030c74 into master Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants