Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multi file download problem #49

Merged
merged 2 commits into from
Mar 20, 2024
Merged

fix multi file download problem #49

merged 2 commits into from
Mar 20, 2024

Conversation

yubaoa
Copy link

@yubaoa yubaoa commented Mar 20, 2024

To fix #47 ‘s download problem
I also met this problem when I was downloading some file using this package.
I found the problem is that both using A TAG to download file and a emitter function callback which is named vf-download, when click the A TAG clickable range,it will call two function both. When just click the the li padding range, it is right.I delete the function using A TAG to download file in template .

@yubaoa
Copy link
Author

yubaoa commented Mar 20, 2024

when I was using unarchive, there is a variable which is called current in ModalUnarchive.vue, I'm not sure if it's right.
I just change it in my local code.
image

@n1crack
Copy link
Owner

n1crack commented Mar 20, 2024

Thank you.

@n1crack n1crack merged commit 7de287c into n1crack:master Mar 20, 2024
@n1crack
Copy link
Owner

n1crack commented Mar 20, 2024

there was a reason behind we make the download link as a link. So it should work as expected now.

And yes we have missed to change "current" to app.data. It is also fixed.

@yubaoa
Copy link
Author

yubaoa commented Mar 20, 2024

got it, you are welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vuefinder locale doesnt work and download files twice
2 participants