-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Components to Use BEM Convention #66
Refactor Components to Use BEM Convention #66
Conversation
Thanks for the contribution, I will check it asap when I'm home. |
@n1crack Sounds good! Let me know if you need help. |
@n1crack was there any specific error that blocking this PR? |
Another project and other things steal my time :). There are small issues, I want to be sure the appearance is exact same as before. It will be merged this weekend. Sorry about the delay |
I appreciate it. Let me know if I can help. |
Separated the styles from sfc files. created their own css (mostly). when we use apply, i think it should be in @ layer, otherwise the result can be different. anyway I think it is ok now. Thanks again.. I will wait for your custom theme :) |
Super! I appreciate it. ❤️ |
Why?
Refactoring components to adopt the BEM (Block Element Modifier) convention for styling and utilizing TailwindCSS as the default styling framework. This change aims to enhance the clarity, maintainability, and customization of the components' styles.
What?
Testing:
The changes have been manually tested to ensure that they function correctly. However, it is highly recommended that @n1crack conducts a comprehensive test drive to verify all aspects of the integration and functionality.
Thank you for considering this update. I believe this refactor will significantly improve the maintainability and flexibility of the Vuefinder.