Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enter the matrix #2

Merged
merged 3 commits into from
May 11, 2020
Merged

Re-enter the matrix #2

merged 3 commits into from
May 11, 2020

Conversation

maxb2
Copy link

@maxb2 maxb2 commented May 11, 2020

I was able to put it all back into a matrix. Here is the build.

@maxb2
Copy link
Author

maxb2 commented May 11, 2020

Here is the build for the new commits.

@maxb2
Copy link
Author

maxb2 commented May 11, 2020

The patch-package warning is still there 🤦

@maxb2
Copy link
Author

maxb2 commented May 11, 2020

I set the build using $(id -u) in case 1000 isn't right. Trying the build again.

@maxb2
Copy link
Author

maxb2 commented May 11, 2020

If PUID doesn't work, we could build the dockerfile to the application-builder stage, then run npm compile in that image. The warning happens when building the dockerfile as well. I'm going to investigate on my local machine.

@maxb2
Copy link
Author

maxb2 commented May 11, 2020

We have to copy in the patch files before installing! And we have to add a line to .npmrc. We can create .npmrc inside the docker build if the unsafe-perms flag is dangerous outside of docker.

@n1ru4l
Copy link
Owner

n1ru4l commented May 11, 2020

@maxb2 I agree, could you fix it and resolve the merge conflicts? Then we can finally deploy today 🎉

@maxb2
Copy link
Author

maxb2 commented May 11, 2020

On it!

@maxb2
Copy link
Author

maxb2 commented May 11, 2020

  • Binary build. Release Page.
  • Docker build. DockerHub. Everything is building twice. Something is wrong with the local cache. The export mode wasn't set to max and the docker-cache itself was being copied into the build during the deployment job. See 6a7db22 for the fix.

@maxb2
Copy link
Author

maxb2 commented May 11, 2020

It should be good after this build. Iterating this stuff sucks...

@maxb2
Copy link
Author

maxb2 commented May 11, 2020

It's done! This is ready to be merged.

@n1ru4l n1ru4l merged commit 968e1b3 into n1ru4l:package-node-binding-alongside-binary May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants