Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skipAuth directive #887

Merged
merged 3 commits into from
Oct 28, 2021
Merged

feat: skipAuth directive #887

merged 3 commits into from
Oct 28, 2021

Conversation

saihaj
Copy link
Collaborator

@saihaj saihaj commented Oct 26, 2021

Adds skipAuth directive to useGenericAuth's protect-all option.

Closes #886

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2021

🦋 Changeset detected

Latest commit: 4883357

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@envelop/generic-auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/theguild/envelop/CY229upiSu7gdXdB4NfYZZKnYVqV
✅ Preview: https://envelop-git-skip-auth-theguild.vercel.app

@theguild-bot
Copy link
Collaborator

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@envelop/generic-auth@1.0.2-alpha-d40a655.0

@theguild-bot
Copy link
Collaborator

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 111840      ✗ 0    
     data_received......................................: 432 MB  8.6 MB/s
     data_sent..........................................: 24 MB   488 kB/s
     envelop_init.......................................: avg=1.44µs   min=200ns   med=600ns   max=1.46ms  p(90)=2.5µs    p(95)=3µs     
     ✓ { mode:envelop-cache-jit }.......................: avg=627ns    min=200ns   med=400ns   max=1.46ms  p(90)=700ns    p(95)=900ns   
     ✓ { mode:envelop-just-cache }......................: avg=951ns    min=400ns   med=700ns   max=1.28ms  p(90)=1µs      p(95)=1.7µs   
     ✓ { mode:graphql-js }..............................: avg=1.8µs    min=300ns   med=1.5µs   max=495.3µs p(90)=2.6µs    p(95)=2.9µs   
     ✓ { mode:prom-tracing }............................: avg=5.94µs   min=1.7µs   med=2.8µs   max=950.5µs p(90)=8.9µs    p(95)=9.9µs   
     envelop_total......................................: avg=438.08µs min=0s      med=218.1µs max=19.63ms p(90)=872.22µs p(95)=1.88ms  
     ✓ { mode:envelop-cache-jit }.......................: avg=206.83µs min=128.2µs med=182.3µs max=12.4ms  p(90)=244.57µs p(95)=283.88µs
     ✓ { mode:envelop-just-cache }......................: avg=494.33µs min=301.1µs med=414.2µs max=14.5ms  p(90)=569µs    p(95)=783.65µs
     ✓ { mode:graphql-js }..............................: avg=724.52µs min=421.6µs med=584.8µs max=18.1ms  p(90)=867.35µs p(95)=1.37ms  
     ✓ { mode:prom-tracing }............................: avg=2.12ms   min=1.45ms  med=1.93ms  max=19.63ms p(90)=2.64ms   p(95)=3.26ms  
     event_loop_lag.....................................: avg=0s       min=0s      med=0s      max=0s      p(90)=0s       p(95)=0s      
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s       min=0s      med=0s      max=0s      p(90)=0s       p(95)=0s      
     ✓ { mode:envelop-cache-jit }.......................: avg=0s       min=0s      med=0s      max=0s      p(90)=0s       p(95)=0s      
     ✓ { mode:envelop-just-cache }......................: avg=0s       min=0s      med=0s      max=0s      p(90)=0s       p(95)=0s      
     ✓ { mode:graphql-js }..............................: avg=0s       min=0s      med=0s      max=0s      p(90)=0s       p(95)=0s      
     ✓ { mode:prom-tracing }............................: avg=0s       min=0s      med=0s      max=0s      p(90)=0s       p(95)=0s      
     graphql_context....................................: avg=9.1µs    min=3.3µs   med=5.3µs   max=9.72ms  p(90)=11.5µs   p(95)=21.1µs  
     ✓ { mode:envelop-cache-jit }.......................: avg=5.58µs   min=3.4µs   med=4.5µs   max=3.14ms  p(90)=5.7µs    p(95)=6.5µs   
     ✓ { mode:envelop-just-cache }......................: avg=9.39µs   min=3.3µs   med=5.4µs   max=9.72ms  p(90)=9.1µs    p(95)=11.2µs  
     ✓ { mode:graphql-js }..............................: avg=13.44µs  min=5.9µs   med=9.3µs   max=5.48ms  p(90)=22.1µs   p(95)=26.7µs  
     ✓ { mode:prom-tracing }............................: avg=15.78µs  min=9µs     med=11.1µs  max=2ms     p(90)=16.9µs   p(95)=28.5µs  
     graphql_execute....................................: avg=463.09µs min=82.5µs  med=319.6µs max=19.17ms p(90)=1.51ms   p(95)=1.82ms  
     ✓ { mode:envelop-cache-jit }.......................: avg=149.16µs min=82.5µs  med=129.8µs max=11.5ms  p(90)=178.3µs  p(95)=207.8µs 
     ✓ { mode:envelop-just-cache }......................: avg=427.55µs min=265.3µs med=359.5µs max=13.51ms p(90)=491.9µs  p(95)=622.9µs 
     ✓ { mode:graphql-js }..............................: avg=470.28µs min=272.7µs med=368.8µs max=17.88ms p(90)=529.75µs p(95)=927.2µs 
     ✓ { mode:prom-tracing }............................: avg=1.97ms   min=1.34ms  med=1.81ms  max=19.17ms p(90)=2.39ms   p(95)=3.08ms  
     graphql_parse......................................: avg=16.43µs  min=3.6µs   med=7.4µs   max=8.6ms   p(90)=40.8µs   p(95)=50.5µs  
     ✓ { mode:envelop-cache-jit }.......................: avg=9.05µs   min=5µs     med=6.8µs   max=5.22ms  p(90)=10.7µs   p(95)=15.6µs  
     ✓ { mode:envelop-just-cache }......................: avg=7.66µs   min=3.6µs   med=5µs     max=1.97ms  p(90)=12.2µs   p(95)=14.4µs  
     ✓ { mode:graphql-js }..............................: avg=23.96µs  min=8.6µs   med=16.2µs  max=8.6ms   p(90)=32.2µs   p(95)=40.8µs  
     ✓ { mode:prom-tracing }............................: avg=60.99µs  min=35.5µs  med=49.25µs max=5.2ms   p(90)=75.8µs   p(95)=88.6µs  
     graphql_validate...................................: avg=78.32µs  min=26.1µs  med=38.6µs  max=12.18ms p(90)=173.5µs  p(95)=208.91µs
     ✓ { mode:envelop-cache-jit }.......................: avg=42.4µs   min=27.6µs  med=35.4µs  max=7.85ms  p(90)=53.6µs   p(95)=64.58µs 
     ✓ { mode:envelop-just-cache }......................: avg=48.76µs  min=26.1µs  med=35.1µs  max=11.87ms p(90)=55.85µs  p(95)=69.47µs 
     ✓ { mode:graphql-js }..............................: avg=215.03µs min=122.9µs med=173.6µs max=12.18ms p(90)=257.1µs  p(95)=312.37µs
     ✓ { mode:prom-tracing }............................: avg=59.69µs  min=35µs    med=45.3µs  max=2.36ms  p(90)=67.9µs   p(95)=81.89µs 
     http_req_blocked...................................: avg=7.86µs   min=1µs     med=2.2µs   max=9.16ms  p(90)=3µs      p(95)=4.5µs   
     http_req_connecting................................: avg=3.62µs   min=0s      med=0s      max=9.02ms  p(90)=0s       p(95)=0s      
     http_req_duration..................................: avg=8.34ms   min=345.5µs med=6.06ms  max=96.85ms p(90)=18.56ms  p(95)=21.36ms 
       { expected_response:true }.......................: avg=8.34ms   min=345.5µs med=6.06ms  max=96.85ms p(90)=18.56ms  p(95)=21.36ms 
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=7.27ms   min=654.8µs med=5.94ms  max=59.74ms p(90)=12.01ms  p(95)=14.54ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=4.66ms   min=345.5µs med=3.49ms  max=45.59ms p(90)=9.95ms   p(95)=12.9ms  
     ✓ { mode:envelop-just-cache }......................: avg=7.67ms   min=760.5µs med=6.12ms  max=61.88ms p(90)=12.76ms  p(95)=15.79ms 
     ✓ { mode:graphql-js }..............................: avg=11.76ms  min=891.2µs med=9.3ms   max=73.93ms p(90)=19.27ms  p(95)=24.22ms 
     ✓ { mode:prom-tracing }............................: avg=23.64ms  min=3.22ms  med=20.87ms max=96.85ms p(90)=39.79ms  p(95)=42.65ms 
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 55920
     http_req_receiving.................................: avg=74.43µs  min=15.7µs  med=31.3µs  max=26.19ms p(90)=56.5µs   p(95)=88.9µs  
     http_req_sending...................................: avg=80.53µs  min=7.3µs   med=12.8µs  max=26.88ms p(90)=33.7µs   p(95)=51.5µs  
     http_req_tls_handshaking...........................: avg=0s       min=0s      med=0s      max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...................................: avg=8.19ms   min=316µs   med=5.96ms  max=96.77ms p(90)=18.27ms  p(95)=21.18ms 
     http_reqs..........................................: 55920   1118.133554/s
     iteration_duration.................................: avg=8.93ms   min=611.4µs med=6.58ms  max=97.24ms p(90)=19.31ms  p(95)=22.02ms 
     iterations.........................................: 55920   1118.133554/s
     vus................................................: 0       min=0         max=20 
     vus_max............................................: 40      min=40        max=40 

@dotansimha dotansimha merged commit 9f63dac into main Oct 28, 2021
@dotansimha dotansimha deleted the skip-auth branch October 28, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useGenericAuth: in protect-all mode ability to skip auth
3 participants