fix: Refactoring of useRunWorkflow to fix race condition #11311
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShireenMissi
added
release/backport
alexgrozav
requested changes
Oct 18, 2024
| const execution = await workflowsStore.getExecution((executionId as string) || ''); | ||
| if ( | ||
| execution && | ||
| (execution.finished || ['error', 'canceled', 'crashed', 'success'].includes(execution.status)) |
There was a problem hiding this comment.
This condition seems to be repeating here and on line 387. Can you please extract it into a isExecutionResolved helper function?
alexgrozav
previously approved these changes
Oct 18, 2024
n8n
|
||||||||||||||||||||||||
| Project |
n8n
|
| Run status |
|
| Run duration | 04m 24s |
| Commit |
|
| Committer | Michael Kret |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
453
|
|
✅ All Cypress E2E specs passed |
netroy
requested changes
Oct 18, 2024
There was a problem hiding this comment.
we should hold off merging this until @ShireenMissi confirms that this fixes the issue.
…custom-approval-operations-in-nodes-that-send-messages-race-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moved clearing of active execution id after push handler
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-2127/node-keeps-on-loading
https://linear.app/n8n/issue/NODE-1480/custom-approval-operations-in-nodes-that-send-messages