Skip to content

Commit

Permalink
Support Decimal type for CollectLimitExec (NVIDIA#1581)
Browse files Browse the repository at this point in the history
* support decimal for collect limit

Signed-off-by: Raza Jafri <rjafri@nvidia.com>

* setting limit to length

Signed-off-by: Raza Jafri <rjafri@nvidia.com>

* removed integration test

Signed-off-by: Raza Jafri <rjafri@nvidia.com>

Co-authored-by: Raza Jafri <rjafri@nvidia.com>
  • Loading branch information
razajafri and razajafri authored Jan 27, 2021
1 parent ade6d1e commit c6a9ada
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/supported_ops.md
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ Accelerator supports are described below.
<td>S</td>
<td>S*</td>
<td>S</td>
<td><b>NS</b></td>
<td>S*</td>
<td><b>NS</b></td>
<td><b>NS</b></td>
<td><b>NS</b></td>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2396,7 +2396,7 @@ object GpuOverrides {
}),
exec[CollectLimitExec](
"Reduce to single partition and apply limit",
ExecChecks(TypeSig.commonCudfTypes, TypeSig.all),
ExecChecks(TypeSig.commonCudfTypes + TypeSig.DECIMAL, TypeSig.all),
(collectLimitExec, conf, p, r) => new GpuCollectLimitMeta(collectLimitExec, conf, p, r))
.disabledByDefault("Collect Limit replacement can be slower on the GPU, if huge number " +
"of rows in a batch it could help by limiting the number of rows transferred from " +
Expand Down

0 comments on commit c6a9ada

Please sign in to comment.