-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
196 reducing cyclomatic complexity #232
Conversation
Standby for fixes to the two failing build tests. |
Do we have pre/post complexity numbers that we could capture here as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few comments. Big changes to TC but we expected that
I have the original XML and its numbers/findings within CAP. I added an additional column for tracking the changes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #232 +/- ##
==========================================
+ Coverage 72.00% 72.93% +0.93%
==========================================
Files 8 8
Lines 2668 2864 +196
Branches 427 442 +15
==========================================
+ Hits 1921 2089 +168
- Misses 583 600 +17
- Partials 164 175 +11 ☔ View full report in Codecov by Sentry. |
…ypto_tc.c - Modify several single returns
FYI: Currently: (Previous CC | New CC) crypto_tc.c:
sadb_routine_inmemory_template.c:
crypto.c:
cryptography_interface_libgcrypt_template.c:
base64url.c
standalone.c:
crypto_error.c:
All new functions added to reduce complexity are also below a score of 15. |
This is missing some DOxygen boilerplate, but I'll add that in after this has been reviewed.
If you guys could review function names, and the refactoring in general that would be helpful. There will be additional TM requests in the near future. This merge mainly deals with TC, and a couple of other minor refactors:
crypto_tc:
Crypto_TC_Apply_Security_Cam
Crypto_TC_Process_Security_Cam
sadb_routine_inmemory_template.c:
sadb_get_operational_sa_from_gvcid
crypto.c:
Crypto_Check_Anti_Replay
cryptography_interface_lib_gcrypt_template.c:
cryptography_aead_encrypt
cryptography_validate_authentication
cryptography_aead_decrypto.c
base64url.c:
base64urlDecode
standalone.c:
crypto_standalone_tm_process