-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
69 rc1.0.3 #70
69 rc1.0.3 #70
Conversation
# Conflicts: # util/CMakeLists.txt
Codecov Report
@@ Coverage Diff @@
## collab_main #70 +/- ##
===============================================
- Coverage 81.64% 81.62% -0.03%
===============================================
Files 17 17
Lines 3940 3941 +1
===============================================
Hits 3217 3217
- Misses 723 724 +1
Continue to review full report at Codecov.
|
static int32_t sadb_get_operational_sa_from_gvcid(uint8_t, uint16_t, uint16_t, uint8_t, SecurityAssociation_t **); | ||
static int32_t sadb_save_sa(SecurityAssociation_t *sa); | ||
static int32_t sadb_get_sa_from_spi(uint16_t, SecurityAssociation_t* *); | ||
static int32_t sadb_get_operational_sa_from_gvcid(uint8_t, uint16_t, uint16_t, uint8_t, SecurityAssociation_t* *); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SecurityAssociation_t** is better... The * * with the space concerns me -- probably works?
(the same * * thing happens in a number of places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I don't see profiling messages with this branch and it builds fine...
Only thing I don't like is the "* *" pointer-pointers, instead of "**"
@@ -81,7 +83,7 @@ int32_t Crypto_Key_OTAR(void) | |||
} | |||
|
|||
count = sdls_frame.pdu.pdu_len - MAC_SIZE; | |||
for (int w = 0; w < 16; w++) | |||
for (w = 0; w < 16; w++) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with pulling out the declaration like this 👎 ... works though /shrug.
Is this ready to roll?