Fix #118, Standardize command responses

nasa · Jul 6, 2024 · 0211fed · 0211fed
1 parent 1f8e29a
commit 0211fed
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/fsw/inc/fm_events.h b/fsw/inc/fm_events.h
@@ -217,10 +217,7 @@
 /**
  * \brief FM Reset Counters Command Event ID
  *
- *  \par Type: DEBUG
- *
- *  This event is type debug because the command resets housekeeping
- *  telemetry counters that also signal the completion of the command.
+ *  \par Type: INFORMATION
  *
  *  \par Cause
  *

diff --git a/fsw/inc/fm_msgdefs.h b/fsw/inc/fm_msgdefs.h
@@ -75,7 +75,7 @@
  *
  *  \par Command Success Verification
  *       - Command counters will be set to zero (see description)
- *       - Debug event #FM_RESET_CMD_EID will be sent
+ *       - Informational event #FM_RESET_CMD_EID will be sent
  *
  *  \par Command Error Conditions
  *       - Invalid command packet length

diff --git a/fsw/src/fm_cmds.c b/fsw/src/fm_cmds.c
@@ -81,7 +81,7 @@ bool FM_ResetCountersCmd(const CFE_SB_Buffer_t *BufPtr)
     FM_GlobalData.ChildCmdWarnCounter = 0;
 
     /* Send command completion event (debug) */
-    CFE_EVS_SendEvent(FM_RESET_CMD_EID, CFE_EVS_EventType_DEBUG, "%s command", CmdText);
+    CFE_EVS_SendEvent(FM_RESET_CMD_EID, CFE_EVS_EventType_INFORMATION, "%s command", CmdText);
 
     return true;
 }

diff --git a/unit-test/fm_cmds_tests.c b/unit-test/fm_cmds_tests.c
@@ -116,7 +116,7 @@ void Test_FM_ResetCountersCmd_Success(void)
 
     UtAssert_INT32_EQ(context_CFE_EVS_SendEvent[0].EventID, FM_RESET_CMD_EID);
 
-    UtAssert_INT32_EQ(context_CFE_EVS_SendEvent[0].EventType, CFE_EVS_EventType_DEBUG);
+    UtAssert_INT32_EQ(context_CFE_EVS_SendEvent[0].EventType, CFE_EVS_EventType_INFORMATION);
 
     strCmpResult = strncmp(ExpectedEventString, context_CFE_EVS_SendEvent[0].Spec, CFE_MISSION_EVS_MAX_MESSAGE_LENGTH);