Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static Code Analysis JSC 2.1 #117

Closed
2 tasks done
dmknutsen opened this issue May 23, 2024 · 0 comments · Fixed by #119
Closed
2 tasks done

Static Code Analysis JSC 2.1 #117

dmknutsen opened this issue May 23, 2024 · 0 comments · Fixed by #119
Labels
bug

Comments

@dmknutsen
Copy link
Contributor

dmknutsen commented May 23, 2024 •
edited by chillfig
Loading

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Handful of static analysis issues. This report records the findings from the static analysis to facilitate their tracking.

Source Folder Source Filename Source Line Source Object Disposition
Buffer Improper Index Access (Medium)        
\apps\fm\fsw\src fm_child.c 805 Filename Will Fix. FM PR #119
\apps\fm\fsw\src fm_child.c 1161 DirName Will Fix. FM PR #119
\apps\fm\fsw\src fm_child.c 1197 EntryName Will Fix. FM PR #119
\apps\fm\fsw\src fm_cmds.c 391 Source1 Will Fix. FM PR #119
\apps\fm\fsw\src fm_cmds.c 393 Target Will Fix. FM PR #119
Unsafe Functions (Medium Risk)        
\apps\fm\fsw\src fm_cmd_utils.c 580 strncpy Will Fix. FM PR #119
\apps\fm\fsw\src fm_cmd_utils.c 610 strncpy Will Fix. FM PR #119
\apps\fm\fsw\src fm_cmd_utils.c 582 strlen Will Fix. FM PR #119

Reporter Info
Dan Knutsen
NASA Goddard
@chillfig chillfig changed the title Static Code Analysis Static Code Analysis JSC 2.1 May 23, 2024
chillfig pushed a commit to chillfig/FM that referenced this issue Jun 10, 2024
Fix nasa#117, Adds JSC 2.1 Static Analysis comments
50808eb
@chillfig chillfig mentioned this issue Jun 10, 2024
Merged
2 tasks
chillfig pushed a commit to chillfig/FM that referenced this issue Jun 14, 2024
Fix nasa#117, Replaces strncpy with snprintf
8157a4d
chillfig pushed a commit to chillfig/FM that referenced this issue Jun 14, 2024
Fix nasa#117, Replaces strncpy with snprintf
a5d0084
chillfig pushed a commit to chillfig/FM that referenced this issue Jun 18, 2024
Fix nasa#117, Replaces strncpy with snprintf
23e2ba1 
This commit addresses issues flagged during static analysis by:
- Replacing strncpy with snprintf to enhance safety and compliance.
- Replacing strlen with FM_strnlen.
chillfig pushed a commit to chillfig/FM that referenced this issue Jun 18, 2024
Fix nasa#117, Replaces strncpy and strlen
4e7796a 
This commit addresses issues flagged during static analysis by:
- Replacing strncpy with snprintf to enhance safety and compliance.
- Replacing strlen with FM_strnlen.
chillfig pushed a commit to chillfig/FM that referenced this issue Jun 21, 2024
Fix nasa#117, Replaces strncpy and strlen
42b13a5 
This commit addresses issues flagged during static analysis by:
- Replacing strncpy with snprintf to enhance safety and compliance.
- Replacing strlen with OS_strnlen.
chillfig pushed a commit to chillfig/FM that referenced this issue Jun 27, 2024
Fix nasa#117, Replaces strncpy and strlen
bbea4a2 
This commit addresses issues flagged during static analysis by:
- Replacing strncpy with snprintf to enhance safety and compliance.
- Replacing strlen with OS_strnlen.
@dzbaker dzbaker closed this as completed in f664494 Jul 2, 2024
dzbaker added a commit that referenced this issue Jul 2, 2024
@dzbaker
Merge pull request #119 from chillfig/SA_jsc2_1
1f8e29a 
Fix #117, Replaces strncpy and strlen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #117, Replaces strncpy and strlen chillfig/FM
2 participants
@dmknutsen @chillfig