Fix #15, Refactor LC_SendHkCmd()
to reduce switch
duplication
#93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
LC_HousekeepingReq()
(previously namedLC_SampleAPReq()
) to combine 4switch
blocks into 1 for the watch results, and 4switch
blocks into 2 for the action points.LC_SampleAPReq()
to reduce nesting a little (early continue infor
loop)LC_SampleAPReq
is to add an early return to the firstif
condition, or to combine the 1stif
condition with the 2nd (which results in a triple if-condition which is less clear than the current implementation) - it did not seem worth making these changes.Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Coverage Tests etc.).
Expected behavior changes
No change to behavior.
Contributor Info
Avi Weiss @thnkslprpt