Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unit test stubs to use size_t #217

Closed
jphickey opened this issue Nov 17, 2020 · 0 comments · Fixed by #219 or #221
Closed

Update unit test stubs to use size_t #217

jphickey opened this issue Nov 17, 2020 · 0 comments · Fixed by #219 or #221
Assignees
@jphickey
Labels
dependency enhancement New feature or request unit-test
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As part of nasa/osal#635 the unit test routines were updated to use size_t rather than uint32 for object sizes.

Describe the solution you'd like
PSP stub implementations need to use size_t instead of uint32 to avoid a compiler type mismatch error on some platforms.

Additional context
This needs to go with/dependency on PR nasa/osal#654.

This issue is only for stubs as it will cause a build issue without it. There will be a separate change/to-do item to fix PSP FSW APIs that are still using uint32.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Nov 17, 2020
@jphickey jphickey added dependency enhancement New feature or request labels Nov 17, 2020
jphickey added a commit to jphickey/PSP that referenced this issue Nov 17, 2020
@jphickey
Fix nasa#217, use size_t in PSP stubs
45718d9 
Recent API updates require use of the size_t type
instead of uint32.
@jphickey jphickey mentioned this issue Nov 17, 2020
Merged
astrogeco added a commit that referenced this issue Nov 23, 2020
@astrogeco
Merge pull request #219 from jphickey/fix-217-stubs-use-size_t
dd9fd53 
Fix #217, use size_t in PSP stubs
@astrogeco astrogeco added this to the 1.6.0 milestone Nov 23, 2020
@astrogeco astrogeco mentioned this issue Dec 1, 2020
Merged
ArielSAdamsNASA pushed a commit that referenced this issue Jan 7, 2021
@jphickey @arielswalker
Fix #217, use size_t in PSP stubs
a8d2e39 
Recent API updates require use of the size_t type
instead of uint32.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
dependency enhancement New feature or request unit-test
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Fix #217, use size_t in PSP stubs jphickey/PSP
psp Integration Candidate: 2020-11-24 nasa/PSP
2 participants
@jphickey @astrogeco