Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Workflow check catching empty function #364

Closed
thnkslprpt opened this issue Oct 7, 2022 · 0 comments · Fixed by #365
Closed

CI Workflow check catching empty function #364

thnkslprpt opened this issue Oct 7, 2022 · 0 comments · Fixed by #365
Milestone

Comments

@thnkslprpt
Copy link
Contributor

    > > @thnkslprpt Can you take a look at the format check workflow and fix the issue caught by it? Specifically about `void CFE_PSP_SetDefaultExceptionEnvironment(void)`. Thank you!

It seems that the warning was deemed ignorable in this case, given that the pull request was merged, which is good because I was having trouble deciphering exactly what the error was referring to anyway. Was it just due to the empty function?

The "error on differences" step of the format check workflow (https://github.com/nasa/PSP/actions/runs/3163591969/jobs/5151273223) looks something like this:

16 -void CFE_PSP_SetDefaultExceptionEnvironment(void)
17 -{
18 -}
19 +void CFE_PSP_SetDefaultExceptionEnvironment(void) {}

The check recommends removing lines 16-18 by "-" before the line. The check recommends adding line 19 by showing "+" before the line.

Originally posted by @chillfig in #360 (comment)

@dzbaker dzbaker linked a pull request Oct 13, 2022 that will close this issue
2 tasks
dzbaker added a commit that referenced this issue Oct 17, 2022
Fix #364, Stop empty function catching CI workflow format checks
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants