Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#122, fix lgtm issue #123

Merged
merged 1 commit into from
Jan 13, 2020
Merged

#122, fix lgtm issue #123

merged 1 commit into from
Jan 13, 2020

Conversation

avan989
Copy link
Contributor

@avan989 avan989 commented Dec 18, 2019

Describe the contribution
fix lgtm issue.

Testing performed
Steps taken to test the contribution:

  1. make prep
  2. make
  3. make install
  4. verify still run.
  5. Mock pull request on dummy repository
  6. Verify lgtm indicates issue has been resolve.

System(s) tested on:

  • Hardware
  • Ubuntu 18.04
  • CFE 6.6

Contributor Info
Anh Van, NASA Goddard

@astrogeco astrogeco added CCB:Approved Indicates Approval by CCB and removed CCB:Approved Indicates Approval by CCB labels Jan 13, 2020
@astrogeco
Copy link
Contributor

CCB 20200108 - Reviewed and approved for IC

@astrogeco astrogeco changed the base branch from master to merge-20200108 January 13, 2020 21:07
@astrogeco astrogeco merged commit ab4c4b6 into nasa:merge-20200108 Jan 13, 2020
astrogeco pushed a commit that referenced this pull request Jan 13, 2020
Fix #123
Reviewed and approved at 2020-01-08 CC
astrogeco pushed a commit that referenced this pull request Jan 13, 2020
Fix #122
Reviewed and approved at 2020-01-08 CCB
astrogeco pushed a commit that referenced this pull request Jan 13, 2020
Fix #122
Reviewed and approved at 2020-01-08 CCB
@skliper skliper added this to the 1.5.0 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates Approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants