Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate target_include_directories command in CMakeLists.txt #136

Closed
2 tasks done
thnkslprpt opened this issue Jan 30, 2024 · 0 comments · Fixed by #137
Closed
2 tasks done

Duplicate target_include_directories command in CMakeLists.txt #136

thnkslprpt opened this issue Jan 30, 2024 · 0 comments · Fixed by #137

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Identical target_include_directories commands were pasted into the CMakeLists.txt a little while ago.

Code snips

SC/CMakeLists.txt

Lines 17 to 29 in 29f7bad

# This permits direct access to public headers in the fsw/inc directory
target_include_directories(sc PUBLIC fsw/inc)
set(APP_TABLE_FILES
fsw/tables/sc_rts001.c
fsw/tables/sc_ats1.c
fsw/tables/sc_rts002.c
)
add_cfe_tables(sc ${APP_TABLE_FILES})
# This permits direct access to public headers in the fsw/inc directory
target_include_directories(sc PUBLIC fsw/inc)

Expected behavior
Remove duplicate.

Reporter Info
Avi Weiss   @thnkslprpt

thnkslprpt added a commit to thnkslprpt/SC that referenced this issue Jan 30, 2024
dzbaker added a commit that referenced this issue Feb 8, 2024
…e-command

Fix #136, Remove duplicate `target_include_directories` cmake command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant