Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static analysis issues JSC 2.1 #140

Closed
2 tasks done
chillfig opened this issue Apr 24, 2024 · 0 comments · Fixed by #144
Closed
2 tasks done

Static analysis issues JSC 2.1 #140

chillfig opened this issue Apr 24, 2024 · 0 comments · Fixed by #144
Assignees
Labels

Comments

@chillfig
Copy link
Contributor

chillfig commented Apr 24, 2024

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Handful of static analysis issues. This report records the findings from the static analysis to facilitate their tracking.

Source Folder Source Filename Source Line Source Object Disposition
Unchecked Array Index        
\apps\sc\fsw\src sc_app.c 156 SC_RTP Will Not Fix. SC_ATP is 0, within the valid index range of NextCmdTime array, which has 2 elements.
\apps\sc\fsw\src sc_app.c 155 SC_ATP Will Not Fix. SC_RTP is 1, within the valid index range of NextCmdTime array, which has 2 elements.
Unchecked Return Value of a Function        
\apps\sc\fsw\src sc_app.c 355 snprintf Will Not Fix. No need to check snprintf return value; TableName's buffer is large enough to safely hold SC_ATS_CMD_STAT_TABLE_NAME with the added index.
\apps\sc\fsw\src sc_app.c 392 snprintf Will Not Fix. No need to check snprintf return value; TableName's buffer is large enough to safely hold CFE_MISSION_TBL_MAX_NAME_LENGTH with the added table identifiers.

To Reproduce
N/A. These issues were communicated by JSC.

Expected behavior
Need to resolve these. Should resolve and/or disposition the higher ranked ones at minimum.

Code snips
N/A

System observed on:
N/A

Additional context
N/A

Reporter Info
Imported from JSC 2.1 static analysis

@chillfig chillfig added the bug label Apr 24, 2024
@chillfig chillfig self-assigned this Apr 24, 2024
chillfig pushed a commit to chillfig/SC that referenced this issue Jun 10, 2024
chillfig pushed a commit to chillfig/SC that referenced this issue Jun 14, 2024
dzbaker added a commit that referenced this issue Jun 27, 2024
Fix #140, Adds JSC 2.1 Static Analysis comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant