Fix #138, Unit test update for 1 based SC_LAST_RTS_WITH_EVENTS #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
force-pushed
the
fix138-last_rts_1_based
branch
from
6a16aa7
to
60f2e3b
Compare
pepepr08
approved these changes
Jan 31, 2024
jphickey
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
SC_LAST_RTS_WITH_EVENTS#138Testing performed
Built and ran tests locally with
SC_LAST_RTS_WITH_EVENTSset toSC_NUMBER_OF_RTSwithBUILDTYPE=release, workedExpected behavior changes
Correct indexing and more sensible msg size.
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC
Ping @pepepr08 - we need this to compile unit tests with BUILDTYPE=release