Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #63, Remove initializations causing Cppcheck errors #64

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution
Fixes #63
Both seem fine to change from initialization at the top of the function to a plain declaration.
TempAtsChar is used in only one location, and that is after a mutually exclusive if/else which assigns it a value in both cases.
IndexDelta is used inside just one if block, and is assigned a value (on line 409) before any of the 3 references to it are made.

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes
No impact on code behavior.
Cppcheck now passes without error again.

Contributor Info
Avi @thnkslprpt

Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing, we should merge this, as it fixes one of the workflow errors in main branch.

@dzbaker dzbaker merged commit 487169b into nasa:main Jan 12, 2023
@thnkslprpt thnkslprpt deleted the fix-63-remove-initializations-causing-cppcheck-failure branch January 12, 2023 21:58
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Cppcheck errors: '[unreadVariable]'
4 participants