Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use %s, _func_ for all syslog messages #1325

Closed
skliper opened this issue Apr 13, 2021 · 0 comments · Fixed by #1611 or #1619
Closed

Use %s, _func_ for all syslog messages #1325

skliper opened this issue Apr 13, 2021 · 0 comments · Fixed by #1611 or #1619
Labels
CFS-40 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Apr 13, 2021

Is your feature request related to a problem? Please describe.
Function name copy/paste mistakes and various reporting formats used in CFE_ES_SysLogWrite_Unsync and CFE_ES_SysLogWrite:

cFE/modules/es/fsw/src/cfe_es_api.c

Line 238 in e80aae9

CFE_ES_SysLogWrite_Unsync("CFE_ES_DeleteApp: Cannot Reload a CORE Application: %s.\n",

Describe the solution you'd like
Use a common format %s: message, _FUNCTION_, ...

Describe alternatives you've considered
Could use a macro

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC

Ping @dmknutsen - may require test update when checking for specific messages
@skliper skliper added this to the 7.0.0 milestone Apr 13, 2021
@skliper skliper added the CFS-40 label Apr 13, 2021
@skliper skliper mentioned this issue May 12, 2021
Open
@skliper skliper changed the title Use %s, _FUNCTION_ for all syslog messages Use %s, _func_ for all syslog messages May 21, 2021
skliper added a commit to skliper/cFE that referenced this issue Jun 7, 2021
@skliper
Fix nasa#1325, Prepend CFE_ES_SysLogWrite_Unsync with function name
306593b
skliper added a commit to skliper/cFE that referenced this issue Jun 7, 2021
@skliper
Fix nasa#1325, Prepend CFE_ES_WriteToSysLog with function name
5d7d047
skliper added a commit to skliper/cFE that referenced this issue Jun 7, 2021
@skliper
Fix nasa#1325, Prepend system log writes with function name
f03f104
skliper added a commit to skliper/cFE that referenced this issue Jun 8, 2021
@skliper
Fix nasa#1325, UT updates for syslog function prefix
fa3d5f8
@skliper skliper mentioned this issue Jun 8, 2021
Merged
skliper added a commit to skliper/cFE that referenced this issue Jun 8, 2021
@skliper
Fix nasa#1325, Prepend system log writes with function name
ed2fa95
skliper added a commit to skliper/cFE that referenced this issue Jun 8, 2021
@skliper
Fix nasa#1325, UT updates for syslog function prefix
43d6789
skliper added a commit to skliper/cFE that referenced this issue Jun 15, 2021
@skliper
Fix nasa#1325, Prepend system log writes with function name
faff2dc
skliper added a commit to skliper/cFE that referenced this issue Jun 15, 2021
@skliper
Fix nasa#1325, UT updates for syslog function prefix
6167442
skliper added a commit to skliper/cFE that referenced this issue Jun 15, 2021
@skliper
Fix nasa#1325, UT updates for syslog function prefix
bdd27bd
skliper added a commit to skliper/cFE that referenced this issue Jun 15, 2021
@skliper
Fix nasa#1325, UT updates for syslog function prefix
abe68b5
astrogeco added a commit that referenced this issue Jun 15, 2021
@astrogeco
Merge pull request #1611 from skliper/fix1325-syslog_func
8752126 
Fix #1325, Prepend system log messages with function name
@astrogeco astrogeco mentioned this issue Jun 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CFS-40 enhancement
Projects
None yet
Milestone
Caelum
1 participant
@skliper