Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case of too many tokens in startup file #1330

Closed
skliper opened this issue Apr 13, 2021 · 1 comment · Fixed by #1370 or #1431
Closed

Handle case of too many tokens in startup file #1330

skliper opened this issue Apr 13, 2021 · 1 comment · Fixed by #1370 or #1431
Assignees
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Apr 13, 2021

Is your feature request related to a problem? Please describe.
Silently consumes , if NumTokens == CFE_ES_STARTSCRIPT_MAX_TOKENS_PER_LINE:

if (NumTokens < (CFE_ES_STARTSCRIPT_MAX_TOKENS_PER_LINE - 1))

Looks like it would just concatenate entries after that point, which could lead to strange errors

Describe the solution you'd like
Warn/error/report/abort

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 7.0.0 milestone Apr 13, 2021
@jphickey
Copy link
Contributor

Suggest a warning is probably most prudent here, it will at least tell the user there is something wrong. I don't want to abort though, since there is always a chance that the app being started by that line isn't critical. I would not want to trade a degraded but (potentially) functional result for a completely non-functional result by aborting.

jphickey added a commit to jphickey/cFE that referenced this issue Apr 16, 2021
This improves the log message when a line in the startup script is
not formed correctly, such as being too long or having too many
tokens.
jphickey added a commit to jphickey/cFE that referenced this issue Apr 16, 2021
This improves the log message when a line in the startup script is
not formed correctly, such as being too long or having too many
tokens.
jphickey added a commit to jphickey/cFE that referenced this issue Apr 16, 2021
This improves the log message when a line in the startup script is
not formed correctly, such as being too long or having too many
tokens.
jphickey added a commit to jphickey/cFE that referenced this issue Apr 20, 2021
astrogeco added a commit that referenced this issue Apr 28, 2021
Fix #1330, better warning about malformed startup line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants