Combine mostly duplicated logic in CFE_SB_BroadcastBufferToRoute

[skliper]

Is your feature request related to a problem? Please describe.
Duplicated logic:

cFE/modules/sb/fsw/src/cfe_sb_api.c

Lines 1650 to 1667 in c8b5e00

	else if (Status == OS_QUEUE_FULL)
	{
	SBSndErr.EvtBuf[SBSndErr.EvtsToSnd].PipeId = DestPtr->PipeId;
	SBSndErr.EvtBuf[SBSndErr.EvtsToSnd].EventId = CFE_SB_Q_FULL_ERR_EID;
	SBSndErr.EvtsToSnd++;
	CFE_SB_Global.HKTlmMsg.Payload.PipeOverflowErrorCounter++;
	PipeDscPtr->SendErrors++;
	}
	else
	{
	/* Unexpected error while writing to queue. */
	SBSndErr.EvtBuf[SBSndErr.EvtsToSnd].PipeId = DestPtr->PipeId;
	SBSndErr.EvtBuf[SBSndErr.EvtsToSnd].EventId = CFE_SB_Q_WR_ERR_EID;
	SBSndErr.EvtBuf[SBSndErr.EvtsToSnd].ErrStat = Status;
	SBSndErr.EvtsToSnd++;
	CFE_SB_Global.HKTlmMsg.Payload.InternalErrorCounter++;
	PipeDscPtr->SendErrors++;
	} /*end if */

Describe the solution you'd like
Factor out, make an else with shared logic and internal if for the unique logic

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC

[thnkslprpt]

You're thinking something like this Jake (@skliper)?

cFE/modules/sb/fsw/src/cfe_sb_api.c

Lines 1661 to 1678 in 3d8829e

	else
	{
	SBSndErr.EvtBuf[SBSndErr.EvtsToSnd].PipeId = DestPtr->PipeId;
	if (OsStatus == OS_QUEUE_FULL)
	{
	SBSndErr.EvtBuf[SBSndErr.EvtsToSnd].EventId = CFE_SB_Q_FULL_ERR_EID;
	CFE_SB_Global.HKTlmMsg.Payload.PipeOverflowErrorCounter++;
	}
	else
	{
	/* Unexpected error while writing to queue. */
	SBSndErr.EvtBuf[SBSndErr.EvtsToSnd].EventId = CFE_SB_Q_WR_ERR_EID;
	SBSndErr.EvtBuf[SBSndErr.EvtsToSnd].OsStatus = OsStatus;
	CFE_SB_Global.HKTlmMsg.Payload.InternalErrorCounter++;
	}
	SBSndErr.EvtsToSnd++;
	PipeDscPtr->SendErrors++;
	} /*end if */

[skliper]

@thnkslprpt - looks good!

[thnkslprpt]

Cheers Jake.