Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow updating more than just SequenceCount on message transmit #2335

Closed
jphickey opened this issue May 17, 2023 · 1 comment · Fixed by #2336
Closed

Allow updating more than just SequenceCount on message transmit #2335

jphickey opened this issue May 17, 2023 · 1 comment · Fixed by #2336
Assignees
@jphickey
Labels
enhancement Equuleus-rc1
Milestone
Equuleus

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, the CFE_SB_TransmitMsg() API has a second parameter, to update the sequence count of the outgoing message.

This was a bit short-sighted because the MSG headers are user-configurable (via customizing the MSG module) ... it is possible that there is more than just a Sequence Count that needs to be maintained. If users can add custom header fields, this hook needs to be more generic to update other headers.

Describe the solution you'd like
Generalize the boolean to mean "Update Headers" (thus not limited to a sequence count). This would include a sequence count, of course, to not break existing code.

Additional context
Other headers that could conceivably be updated, if applicable to the message being sent:

  • Timestamp
  • Checksum/error control field

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this May 17, 2023
@jphickey
Copy link
Contributor Author

This overlaps/supercedes my old issue #1157 ... which was similar in the sense that the boolean on this function was oddly implemented and too limited in nature.

jphickey added a commit to jphickey/cFE that referenced this issue May 17, 2023
@jphickey
Fix nasa#2335, generalize update header parameter
c13e761 
Expand the "Increment Sequence" boolean on transmit message functions to
be a more general "Update Header" boolean, so it can be used for other
fields like timestamps, checksums, or user-defined fields too.
@jphickey jphickey mentioned this issue May 17, 2023
Merged
2 tasks
dzbaker added a commit that referenced this issue May 22, 2023
@dzbaker
Merge pull request #2336 from jphickey/fix-2335-update-header
691f1f7 
Fix #2335, generalize update header parameter
@dzbaker dzbaker mentioned this issue May 22, 2023
Merged
2 tasks
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement Equuleus-rc1
Projects
None yet
Milestone
Equuleus
Development

Successfully merging a pull request may close this issue.

Fix #2335, generalize update header parameter jphickey/cFE
3 participants
@jphickey @dmknutsen @chillfig