Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out-of-date CFE_PLATFORM_ES_DEFAULT_SYSLOG_MODE macro in cfe_es_verify.h #2343

Closed
2 tasks done
thnkslprpt opened this issue May 21, 2023 · 0 comments · Fixed by #2344
Closed
2 tasks done

Out-of-date CFE_PLATFORM_ES_DEFAULT_SYSLOG_MODE macro in cfe_es_verify.h #2343

thnkslprpt opened this issue May 21, 2023 · 0 comments · Fixed by #2344

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
CFE_PLATFORM_ES_DEFAULT_SYSLOG_MODE was split into CFE_PLATFORM_ES_DEFAULT_POR_SYSLOG_MODE and CFE_PLATFORM_ES_DEFAULT_PR_SYSLOG_MODE, but the checks in cfe_es_verify.h got missed (so this check is not actually checking anything right now).

Code snips

/*
** SysLog mode
*/
#if CFE_PLATFORM_ES_DEFAULT_SYSLOG_MODE < 0
#error CFE_PLATFORM_ES_DEFAULT_SYSLOG_MODE cannot be less than 0!
#elif CFE_PLATFORM_ES_DEFAULT_SYSLOG_MODE > 1
#error CFE_PLATFORM_ES_DEFAULT_SYSLOG_MODE cannot be greater than 1!
#endif

Expected behavior
Update this compile-time check to use the new macros.

Reporter Info
Avi Weiss @thnkslprpt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants