Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure of ut_time_stubs with BUILDTYPE=release #487

Closed
skliper opened this issue Jan 22, 2020 · 1 comment · Fixed by #504 or #544
Closed

Build failure of ut_time_stubs with BUILDTYPE=release #487

skliper opened this issue Jan 22, 2020 · 1 comment · Fixed by #504 or #544
Assignees
Labels
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Jan 22, 2020

Describe the bug
Matrix build fails with: BUILDTYPE=release OMIT_DEPRECATED=false
See also nasa/cFS#40 (enhanced CI)

To Reproduce
Steps to reproduce the behavior:

  1. See CI process/results

Expected behavior
Successful build

Error text

home/travis/build/nasa/cFS/cfe/fsw/cfe-core/ut-stubs/ut_time_stubs.c: In function ‘CFE_TIME_Print’:
/home/travis/build/nasa/cFS/cfe/fsw/cfe-core/ut-stubs/ut_time_stubs.c:106:25: error: ‘ -’ directive output may be truncated writing 2 bytes into a region of size between 0 and 18 [-Werror=format-truncation=]
              "UT %lu.%lu -",
                         ^~
In file included from /usr/include/stdio.h:862:0,
                 from /home/travis/build/nasa/cFS/cfe/fsw/cfe-core/ut-stubs/ut_time_stubs.c:35:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10: note: ‘__builtin___snprintf_chk’ output between 9 and 27 bytes into a destination of size 24
   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        __bos (__s), __fmt, __va_arg_pack ());
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

System observed on:

  • CI system, integration candidate bundle

Additional context
N/A

Reporter Info
Jacob Hageman - NASA/GSFC

@skliper
Copy link
Contributor Author

skliper commented Jan 28, 2020

@dmknutsen I haven't figured out static links to CI results, but from nasa/cFS#40, click on Details for Travis CI, then click on the failed job you are interested in (99.2 if looking at my latest rebase). Under job log you'll see the same error text as above.

dmknutsen added a commit to dmknutsen/cFE that referenced this issue Jan 31, 2020
Fixes nasa#487, Build failure of ut_time_stubs with BUILDTYPE=release

Fixes nasa#487, Build failure of ut_time_stubs with BUILDTYPE=release
dmknutsen added a commit to dmknutsen/cFE that referenced this issue Jan 31, 2020
@skliper skliper added the bug label Feb 10, 2020
@skliper skliper added this to the 6.8.0 milestone Feb 25, 2020
dmknutsen added a commit to dmknutsen/cFE that referenced this issue Feb 25, 2020
now int to avoid possible string buffer overflow
astrogeco added a commit that referenced this issue Mar 2, 2020
Fix #487, CFE_TIME_print format fix
@astrogeco astrogeco mentioned this issue Mar 10, 2020
@astrogeco astrogeco linked a pull request Mar 10, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants