Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE_SB_GetTotalMsgLength return type doesn't support max packet size #529

Closed
skliper opened this issue Feb 25, 2020 · 1 comment · Fixed by #726 or #833
Closed

CFE_SB_GetTotalMsgLength return type doesn't support max packet size #529

skliper opened this issue Feb 25, 2020 · 1 comment · Fixed by #726 or #833
Labels
bug
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Feb 25, 2020

Is your feature request related to a problem? Please describe.
CFE_SB_GetTotalMsgLength returns an uint16, max packet CCSDS packet size can be slightly bigger (65542 vs 65536). Note the c documentation claims the max return doesn't include the primary header (#528), but the API (h file documentation) claims it's the full packet. The code actually returns the full packet size (the length field in the CCSDS packet + 7).

Describe the solution you'd like
Support full CCSDS packet size.

Describe alternatives you've considered
None

Additional context
Initiated by JP/PACE

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the bug label Feb 25, 2020
@skliper
Copy link
Contributor Author

skliper commented Mar 2, 2020

@jpswinski - FYI

@skliper skliper mentioned this issue Jun 3, 2020
Merged
skliper added a commit to skliper/cFE that referenced this issue Aug 14, 2020
@skliper
Fix nasa#711, Add message header module
d3a073e 
Implements message header module such that users
can customize or extend as needed.
 - Separates code for easier selection
 - Implements consistent getter/setter APIs
 - Fix nasa#736/nasa#781: MsgId logic no longer overrides bits in init
 - Fix nasa#529: Get size supports max size
 - Adds single big endian time implementation, but not selected
 - Adds msg module to module list
 - Adds msg module to cppcheck
@yammajamma yammajamma mentioned this issue Aug 24, 2020
Merged
@astrogeco astrogeco added this to the 7.0.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Caelum
2 participants
@skliper @astrogeco