Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE_TIME_Local1HzISR duplicated define #551

Closed
skliper opened this issue Mar 11, 2020 · 1 comment · Fixed by #668 or #692
Closed

CFE_TIME_Local1HzISR duplicated define #551

skliper opened this issue Mar 11, 2020 · 1 comment · Fixed by #668 or #692
Assignees
@skliper
Labels
bug
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Mar 11, 2020

Is your feature request related to a problem? Please describe.
Defined in both cfe_time.h and cfe_time_utils.h (standard violation)

Describe the solution you'd like
Single source of truth

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 6.8.0 milestone Mar 11, 2020
@skliper
Copy link
Contributor Author

skliper commented Mar 11, 2020

Note its defined in cfe_time_tone.c (not cfe_time_api.c), and doesn't match the pattern used for tone (API wraps internal ISR).

@skliper skliper mentioned this issue May 5, 2020
Open
skliper added a commit to skliper/cFE that referenced this issue May 5, 2020
@skliper
Fix nasa#551, Remove duplicate CFE_TIME_Local1HzISR prototype
48d7a11
@skliper skliper mentioned this issue May 5, 2020
Merged
@skliper skliper self-assigned this May 5, 2020
astrogeco added a commit that referenced this issue May 8, 2020
@astrogeco
Merge pull request #668 from skliper/fix551-dup-local1hzisr-proto
532c0dc 
Fix #551, Remove duplicate CFE_TIME_Local1HzISR prototype
@astrogeco astrogeco mentioned this issue May 13, 2020
Merged
@astrogeco astrogeco added bug and removed enhancement labels Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
bug
Projects
None yet
Milestone
Bootes
3 participants
@skliper @dmknutsen @astrogeco