CFE needs to compile with the interface properties provided by OSAL #581
Comments
|
Note this should supercede the previous request in #532. That approach had issues where the flags were not being correctly applied to app code. |
jphickey
added a commit
to jphickey/cFE
that referenced
this issue
Apr 2, 2020
Use the INTERFACE_COMPILE_DEFINITIONS and INTERFACE_INCLUDE_DIRECTORIES properties from the osal target and apply them to the entire CFE build. At this time, the OSAL library build does not use/export these properties so this is effectively a no-op for the CFE build and can be merged with no effect. However, in a future version, the OSAL library will export these interface properties and this will become important.
astrogeco
added a commit
that referenced
this issue
Apr 14, 2020
Fix #581, Propagate the OSAL compile definitions to CFE build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
After the changes introduced by nasa/osal#312, the OSAL CMake script will no longer force setting of
CMAKE_C_FLAGSdirectly in the CFE build by overwriting this value (which is good).Instead, any required compile definitions and related information will be conveyed in the more appropriate manner, through the
INTERFACE_COMPILE_DEFINITIONSandINTERFACE_INCLUDE_DIRECTORIESon the "osal" library target.Describe the solution you'd like
To work with this change, the CFE needs to explicitly check these properties on the osal target and use the values. By setting a directory-scope property at the top level, it will apply to all code.
Describe alternatives you've considered
CMake does this automatically so long as the executable directly links with OSAL. However, this doesn't apply to the apps which are built as a
MODULE. This is why it is easier to set the directory property so its all-inclusive.Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: