Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace calls OS_open and OS_create with OS_OpenCreate #893

Closed
jphickey opened this issue Sep 21, 2020 · 0 comments · Fixed by #895 or #912
Closed

Replace calls OS_open and OS_create with OS_OpenCreate #893

jphickey opened this issue Sep 21, 2020 · 0 comments · Fixed by #895 or #912
Assignees
@jphickey
Labels
enhancement
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
For nasa/osal#556 the OS_open() and OS_create() API calls will be deprecated, because they don't follow the correct pattern of returning an OSAL ID via an output variable, instead returning the ID via the int32 return code.

Describe the solution you'd like
Use the newly exposed OSAL API OS_OpenCreate() which can replace both OS_open and OS_creat via different flags, and outputs the ID as all other OSAL functions do.

Additional context
Prerequisite to being able to deprecate these APIs that don't follow the OSAL pattern.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey mentioned this issue Sep 21, 2020
Closed
@skliper skliper added this to the 7.0.0 milestone Sep 21, 2020
jphickey added a commit to jphickey/cFE that referenced this issue Sep 22, 2020
@jphickey
Fix nasa#893, replace calls to OS_open and OS_creat
06e0a63 
Use OS_OpenCreate instead, which has an API consistent with the
rest of OSAL.  OS_open and OS_create will be deprecated.
@jphickey jphickey mentioned this issue Sep 22, 2020
Merged
yammajamma added a commit that referenced this issue Sep 24, 2020
@yammajamma
Merge pull request #895 from jphickey/fix-893-osal-open-create
56254e9 
Fix #893, replace calls to OS_open and OS_creat
@yammajamma yammajamma mentioned this issue Sep 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @skliper