Fix #952, OSAL module flags to permit app reload #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the newly-added flags parameter on the OS_ModuleLoad properly to allow an app to be properly unloaded, which in turn allows the reload command to work as expected.
jphickey
added
the
CCB:Ready
|
CCB 2020-12-09 APPROVED |
astrogeco
added
CCB-20201209
and removed
CCB:Ready
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Set the flags parameter on the
OS_ModuleLoad()properly to allow an app to be properly unloaded, which in turn allows the reload command to work as expected.Fixes #952
Testing performed
Build and run all unit tests
Test CFE app reload procedure:
OS_printf()call during startup, and install assample_new.so/cf/sample_new.soExpected behavior changes
Module unload/reload works as expected on Linux. Previously the unload would not actually unload, so it would end up restarting the same app code over again.
System(s) tested on
Ubuntu 20.04
Additional context
Needs sync delete fix in OSAL (see nasa/osal#642) to avoid task delete race condition. Without this OSAL change, the task may still be running at the time CFE ES unloads it, which will likely cause a segfault/crash if that happens.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.