Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1062 - remove CFE_SB_TimeOut_t typedef #1063

Conversation

CDKnightNASA
Copy link
Contributor

Closes #1062

Describe the contribution
Removes the spurious CFE_SB_TimeOut_t typedef from cfe_sb.h

Testing performed
SB unit test

Expected behavior changes
None, may affect any apps that rely on the typedef (which they probably haven't done, given that no public API's use it.)

Contributor Info - All information REQUIRED for consideration of pull request
Christopher.D.Knight@nasa.gov

@CDKnightNASA CDKnightNASA self-assigned this Jan 5, 2021
@CDKnightNASA CDKnightNASA added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 5, 2021
@astrogeco
Copy link
Contributor

CCB 2021-01-06 APPROVED

@CDKnightNASA
Copy link
Contributor Author

20200106 - CCB approved, Joe mentioned that it should probably be an int32 not uint32, will create a separate ticket for that.

@astrogeco astrogeco added CCB-20210106 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jan 6, 2021
@CDKnightNASA CDKnightNASA added CCB:Ready Ready for discussion at the Configuration Control Board (CCB) CCB:Approved Indicates code review and approval by community CCB labels Jan 6, 2021
@astrogeco astrogeco removed CCB:Approved Indicates code review and approval by community CCB CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jan 6, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate January 12, 2021 19:06
@astrogeco astrogeco merged commit eb93d21 into nasa:integration-candidate Jan 12, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 12, 2021
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFE_SB_ReceiveBuffer() should use CFE_SB_TimeOut_t for the TimeOut parameter
3 participants