-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cFE Integration candidate: Caelum-rc4+dev33 #2232
Conversation
Fix #2228, Update UTs to use correct cmd types
Update remaining cases where the CFE_MSG_CommandHeader_t was used for a command that had no arguments, replacing it with a real data type that is named according to the command. In particular, this introduces a "SendHkCmd" type into all modules, where previously the HK command used CFE_MSG_CommandHeader_t directly.
This includes all the updates to EDS XML files since the Bootes release where they were last synced. This includes EDS files for modules that did not yet have one, and updating the other files to match the current message structures in Draco.
Fix #2230, EDS Updates to match the current mainline
Fix #2228, Update UTs to use correct cmd types
…-enum Fix #2174, Move CRC types and convert to enum
@@ -1571,7 +1571,7 @@ | |||
* See description in header file for argument/return detail | |||
* | |||
*-----------------------------------------------------------------*/ | |||
uint32 CFE_ES_CalculateCRC(const void *DataPtr, size_t DataLength, uint32 InputCRC, uint32 TypeCRC) | |||
uint32 CFE_ES_CalculateCRC(const void *DataPtr, size_t DataLength, uint32 InputCRC, CFE_ES_CrcType_Enum_t TypeCRC) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
@@ -1571,7 +1571,7 @@ | |||
* See description in header file for argument/return detail | |||
* | |||
*-----------------------------------------------------------------*/ | |||
uint32 CFE_ES_CalculateCRC(const void *DataPtr, size_t DataLength, uint32 InputCRC, uint32 TypeCRC) | |||
uint32 CFE_ES_CalculateCRC(const void *DataPtr, size_t DataLength, uint32 InputCRC, CFE_ES_CrcType_Enum_t TypeCRC) |
Check notice
Code scanning / CodeQL-coding-standard
Function too long
@@ -77,14 +77,14 @@ | |||
* Generated stub function for CFE_ES_CalculateCRC() | |||
* ---------------------------------------------------- | |||
*/ | |||
uint32 CFE_ES_CalculateCRC(const void *DataPtr, size_t DataLength, uint32 InputCRC, uint32 TypeCRC) | |||
uint32 CFE_ES_CalculateCRC(const void *DataPtr, size_t DataLength, uint32 InputCRC, CFE_ES_CrcType_Enum_t TypeCRC) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
@@ -77,14 +77,14 @@ | |||
* Generated stub function for CFE_ES_CalculateCRC() | |||
* ---------------------------------------------------- | |||
*/ | |||
uint32 CFE_ES_CalculateCRC(const void *DataPtr, size_t DataLength, uint32 InputCRC, uint32 TypeCRC) | |||
uint32 CFE_ES_CalculateCRC(const void *DataPtr, size_t DataLength, uint32 InputCRC, CFE_ES_CrcType_Enum_t TypeCRC) |
Check notice
Code scanning / CodeQL-coding-standard
Function too long
@@ -655,7 +655,7 @@ | |||
* See description in header file for argument/return detail | |||
* | |||
*-----------------------------------------------------------------*/ | |||
int32 CFE_ES_HousekeepingCmd(const CFE_MSG_CommandHeader_t *data) | |||
int32 CFE_ES_HousekeepingCmd(const CFE_ES_SendHkCmd_t *data) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
@@ -613,7 +613,7 @@ | |||
* See description in header file for argument/return detail | |||
* | |||
*-----------------------------------------------------------------*/ | |||
int32 CFE_EVS_ReportHousekeepingCmd(const CFE_MSG_CommandHeader_t *data) | |||
int32 CFE_EVS_ReportHousekeepingCmd(const CFE_EVS_SendHkCmd_t *data) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
@@ -503,7 +503,7 @@ | |||
* See description in header file for argument/return detail | |||
* | |||
*-----------------------------------------------------------------*/ | |||
int32 CFE_SB_SendHKTlmCmd(const CFE_MSG_CommandHeader_t *data) | |||
int32 CFE_SB_SendHKTlmCmd(const CFE_SB_SendHkCmd_t *data) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
@@ -655,7 +655,7 @@ | |||
* See description in header file for argument/return detail | |||
* | |||
*-----------------------------------------------------------------*/ | |||
int32 CFE_ES_HousekeepingCmd(const CFE_MSG_CommandHeader_t *data) | |||
int32 CFE_ES_HousekeepingCmd(const CFE_ES_SendHkCmd_t *data) |
Check notice
Code scanning / CodeQL-coding-standard
Function too long
Checklist (Please check before submitting)
Describe the contribution
Testing performed
cFS Bundle Checks
cFE Checks
Expected behavior changes
See PRs
System(s) tested on
Ubuntu 20.04
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
@dmknutsen
@jphickey
@thnkslprpt