Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2240, improve 64-bit memory address handling in CMD/TLM #2256

Merged
merged 1 commit into from
Mar 17, 2023

Commits on Mar 14, 2023

  1. Fix nasa#2240, improve 64-bit memory address handling in CMD/TLM

    The "CFE_ES_MemAddress_t" and "CFE_ES_MemOffset_t" types were intended
    to provide a path for easily upgrading the CMD/TLM structs from 32-bit
    to 64-bit memory addresses.  However, this type was a bit overused and
    in some of those use-cases (e.g. in TBL header) it assumed that the type
    was 32-bits during the byte swap ops.  As a result, the type could not
    be changed to 64 bits as intended.
    
    This reverts those cases in TBL back to uint32 (meaning that tables will
    still be limited to 32 bit sizes, even on 64 bit CPUs) but otherwise the
    addresses and sizes in ES/SB telemetry can grow to 64 bits as intended.
    
    For unit tests, correct operation depends on the availablily of an updated
    test macro that can compare integers as "size_t" type. (as opposed to
    uint32).
    jphickey committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    7fa0143 View commit details
    Browse the repository at this point in the history