Fix #2581, Adding bytes read check #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CCB 1 Aug 2024: Approved pending workflow run. |
jphickey
approved these changes
Aug 1, 2024
dzbaker
added
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Aug 2, 2024
*Combines:* cFE equuleus-rc1+dev183 **Includes:** *cFE* - nasa/cFE#2579 - nasa/cFE#2565 - nasa/cFE#2584 - nasa/cFE#2585 - nasa/cFE#2586 - nasa/cFE#2326 Co-authored by: Tvisha Andharia <tandharia@users.noreply.github.com> Co-authored by: Anh Van <avan989@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
This was referenced Aug 2, 2024
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Aug 2, 2024
*Combines:* cFE equuleus-rc1+dev183 **Includes:** *cFE* - nasa/cFE#2579 - nasa/cFE#2565 - nasa/cFE#2584 - nasa/cFE#2585 - nasa/cFE#2586 - nasa/cFE#2326 Co-authored by: Tvisha Andharia <tandharia@users.noreply.github.com> Co-authored by: Anh Van <avan989@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes #2581
Testing performed
Added a unit test to simulate scenario where the file read operation reads fewer bytes than expected.
Expected behavior changes
When a read operation fails, the system now exits the function early, preventing potential undefined behavior.
System(s) tested on
OS: Ubuntu 18.04
Contributor Info - All information REQUIRED for consideration of pull request
Tvisha Andharia - GSFC 582 intern