Add global scope option to omit deprecated items #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a "global_build_options.cmake" file akin to the existing arch_build/mission_build option files. Include an example of this file that optionally does add_definitions() to omit the deprected elements for build testing.
skliper
approved these changes
Jan 9, 2020
skliper
added
the
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #355
Adds a "global_build_options.cmake" file akin to the existing arch_build/mission_build option files. Include an example of this file that optionally does add_definitions() to omit the deprected elements for build testing.
Testing performed
Build with and without the OMIT_DEPRECATED flag on the prep command, and confirm that it is correctly translated to the
add_definition()globally for all tools and FSW code.Expected behavior changes
Affects build system only. No change to runtime behavior.
System(s) tested on:
Ubuntu 18.04 LTS 64-bit
Contributor Info
Joseph Hickey, Vantage Systems, Inc.
Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted