Fix #612, Update coverage compile/link flag options #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSAL now sets these as UT_COVERAGE_COMPILE_FLAGS, UT_COVERAGE_LINK_FLAGS. Building and linking the UT executable needs a corresponding update.
|
@astrogeco requesting FASTTRACK |
skliper
approved these changes
Apr 14, 2020
skliper
added
the
CCB:Ready
|
See Also: Perhaps as a future enhancement the CFE should provide a cmake function to create a ut executable rather than having this logic in each of them. |
|
CCB FastTrack - APPROVED |
astrogeco
removed
the
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
OSAL now sets these as UT_COVERAGE_COMPILE_FLAGS, UT_COVERAGE_LINK_FLAGS.
Building and linking the UT executable needs a corresponding update.
Fixes #612
Testing performed
Build with
ENABLE_UNIT_TESTS=TRUEand confirm that all unit tests are buildingExpected behavior changes
Coverage data (
make lcov) now includes the CFE core code againSystem(s) tested on
Ubuntu 18.04 LTS 64 bit
Additional context
Similar change will be needed in apps (forthcoming)
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.