Fix #652, cmake-based OSAL config #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration Candidate: 2020-04-15
Rather than CFE generating an osconfig.h file directly, it just needs to select file(s) from the defs directory and pass them to OSAL for the config.
jphickey
added
the
CCB:Ready
skliper
approved these changes
Apr 29, 2020
|
Note - this PR is needed to complete the nasa/osal#427 merge and therefore needs to be included into the current integration-candidate branch. |
|
I approve of that approach. |
jphickey
added a commit
that referenced
this pull request
Apr 29, 2020
Fix #652, cmake-based OSAL config
astrogeco
added
IC-20200422
and removed
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Rather than CFE generating an osconfig.h file directly, it just needs to select file(s) from the defs directory and pass them to OSAL for the config.
This makes it compatible with the upcoming nasa/osal#285 change (in PR nasa/osal#427)
Fixes #652
Testing performed
Build code with default provided and confirm that OSAL generates the correct config (osconfig.h) and the build succeeds
Expected behavior changes
Users must now select OSAL options via the CMake file in their defs directory, rather than the
osconfig.hfile.System(s) tested on
Ubuntu 20.04 LTS
Additional context
Correlates with nasa/osal#427
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.