Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #794, Add msg stubs and update SB UT #819

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Aug 18, 2020

Describe the contribution
Fix #794 - Add msg stubs, update SB UT to use them, and remove msg module include from unit tests

Testing performed
Standard build with unit tests enabled, passed.

Expected behavior changes
UTs will now use msg stubs.

System(s) tested on

Additional context
Depends on #726

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added unit-test CCB:Ready Ready for discussion at the Configuration Control Board (CCB) enhancement labels Aug 18, 2020
@skliper skliper added this to the 7.0.0 milestone Aug 18, 2020
@skliper
Copy link
Contributor Author

skliper commented Aug 18, 2020

Ping @excaliburtb

@skliper
Copy link
Contributor Author

skliper commented Aug 19, 2020

Force pushed removal of old header.

@skliper
Copy link
Contributor Author

skliper commented Aug 19, 2020

Need to remove old storage structure.

@astrogeco
Copy link
Contributor

CCB 2020-08-19 APPROVED

@skliper skliper changed the base branch from main to integration-candidate August 20, 2020 14:05
@skliper
Copy link
Contributor Author

skliper commented Aug 20, 2020

Rebased and squashed.

@yammajamma yammajamma added CCB:Approved Indicates code review and approval by community CCB IC-20200819 labels Aug 20, 2020
@yammajamma yammajamma merged commit faebfc1 into nasa:integration-candidate Aug 20, 2020
@yammajamma yammajamma removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Aug 20, 2020
@skliper skliper deleted the fix794-msg-stubs branch February 1, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB enhancement unit-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add msg module stubs, update SB to use them, and no longer include actual msg target in unit test builds
3 participants