HOTFIX: Deprecated time format verify logic fix #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yammajamma
added a commit
to nasa/cFS
that referenced
this pull request
Aug 25, 2020
astrogeco
pushed a commit
to nasa/cFS
that referenced
this pull request
Aug 25, 2020
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 25, 2020
Contains: nasa/cFE#833 nasa/osal#576 nasa/to_lab#58 nasa/sch_lab#52 1. Update submodules for IC-20200819 2. Update cfe to reflect HOTFIX nasa/cFE#838 3. Point submodules to main for IC-20200819 Co-authored-by: Yasir Khan <yasir.majeed@nasa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
HOTFIX - Changes the time format compile time verification logic. Old logic would report error if none of the defines exist, new logic only reports error if the time format is not the default (also works if neither are defined).
Testing performed
Built with time format set to default, time format defines not defined, and time format set to non-default. Responded as expected.
Expected behavior changes
No longer reports error if defines are removed (as is the case in the sample config)
System(s) tested on
Additional context
Fix to PR #801
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC