Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmdUtil.h not being use #24

Closed
avan989 opened this issue Sep 3, 2019 · 1 comment · Fixed by #26
Closed

cmdUtil.h not being use #24

avan989 opened this issue Sep 3, 2019 · 1 comment · Fixed by #26
Assignees
@avan989
Labels
enhancement New feature or request
Milestone
Aquila

Comments

@avan989
Copy link
Contributor

avan989 commented Sep 3, 2019

cmdUtil.h is not being used. Only contain the prototypes for SendUdp. Suggest using it cmdUtil.h or deleting it.
@skliper
Copy link
Contributor

skliper commented Sep 3, 2019

Good call. Requested updates - change the name to SendUdp.h, change sendUdp.c to SendUdp.c, include SendUdp.h in SendUdp.c and cmdUtil.c, remove local prototype of SendUdp in cmdUtil.c.

skliper added a commit that referenced this issue Sep 6, 2019
@skliper
Merge pull request #25 from avan989/cmdUtil_8_18_19
df9f5a6 
Fix #24, cmdUtil not updated
skliper added a commit that referenced this issue Sep 6, 2019
@skliper
CCB 2019-09-04: Merge #24 #4 #12 #6 #11 #5 #7 #14 #1
ae911ab 
Reviewed and approved at 2019-09-04 CCB
@skliper skliper mentioned this issue Sep 6, 2019
Merged
@skliper skliper added the enhancement New feature or request label Sep 6, 2019
@skliper skliper added this to the 2.1.0 milestone Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avan989 avan989

Labels
enhancement New feature or request
Projects
None yet
Milestone
Aquila
Development

Successfully merging a pull request may close this issue.

Integration Candidate 20190906 nasa/cFS-GroundSystem
2 participants
@avan989 @skliper