Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CodeQL workflow dependent on a succesful build #264

Closed
astrogeco opened this issue Jun 8, 2021 · 0 comments · Fixed by #304 or #313
Closed

Make CodeQL workflow dependent on a succesful build #264

astrogeco opened this issue Jun 8, 2021 · 0 comments · Fixed by #304 or #313
Assignees
@ArielSAdamsNASA

Comments

@astrogeco
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The CodeQL workflow runs without any knowledge of whether or not cFS can be built this prevents a "fail-fast" approach to testing and results in wasted github actions cycles.

Describe the solution you'd like
Figure out how to make the CodeQL workflow not run when the main "build and test" job fails.

Describe alternatives you've considered
None

Additional context
This might require the workflow or repository "dispatch" actions.

If successful we can follow this pattern in submodules.
@ArielSAdamsNASA ArielSAdamsNASA self-assigned this Jul 16, 2021
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Jul 16, 2021
@arielswalker
Fix nasa#264, CodeQL Dependent on Successful Build
281f28c
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Jul 16, 2021
@arielswalker
Fix nasa#264, CodeQL Dependent on Successful Build
3c9db50
@ArielSAdamsNASA ArielSAdamsNASA mentioned this issue Jul 16, 2021
Merged
2 tasks
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Jul 16, 2021
@arielswalker
Fix nasa#264, CodeQL Dependent on Successful Build
a003af2
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Jul 16, 2021
@arielswalker
Fix nasa#264, CodeQL Dependent on Successful Build
1ed1793
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Jul 16, 2021
@arielswalker
Fix nasa#264, CodeQL Dependent on Successful Build
75ee066
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Jul 19, 2021
@arielswalker
Fix nasa#264, CodeQL Dependent on Successful Build
5724e49
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Jul 19, 2021
@arielswalker
Fix nasa#264, CodeQL Dependent on Successful Build
7c04605
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Jul 19, 2021
@arielswalker
Fix nasa#264, CodeQL Dependent on Successful Build
b7415bb
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Jul 20, 2021
@arielswalker
Fix nasa#264, CodeQL Dependent on Successful Build
2649a44
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Jul 20, 2021
@arielswalker
Fix nasa#264, CodeQL Dependent on Successful Build
41f6b61
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Jul 20, 2021
@arielswalker
Fix nasa#264, CodeQL Dependent on Successful Build
a146436
astrogeco added a commit that referenced this issue Jul 21, 2021
@astrogeco
Merge pull request #304 from ArielSAdamsNASA/fix-264-CodeQL-dependent…
da741e1 
…-on-successful-build

Fix #264, CodeQL Dependent on a Successful Build
@astrogeco astrogeco mentioned this issue Jul 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArielSAdamsNASA ArielSAdamsNASA

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@astrogeco @ArielSAdamsNASA