Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #167, Update doc generation action error check #168

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jan 4, 2021

Describe the contribution
Fix #167

Warning file is moved in Build Usersguide step.
Updated from checking the old file location to
checking the moved file.

Testing performed
Pushed to fork and observed the doc warnings are reported in actions.

Expected behavior changes
Actually reports when warnings are generated

System(s) tested on

  • Hardware: CI

Additional context
Actual fixes to the warnings will be in respective repos

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

Warning file is moved in Build Usersguide step.
Updated from checking the old file location to
checking the moved file.
@skliper skliper requested a review from astrogeco January 4, 2021 16:38
@astrogeco astrogeco changed the base branch from main to integration-candidate January 5, 2021 22:24
@astrogeco astrogeco merged commit 57c78c7 into nasa:integration-candidate Jan 5, 2021
@skliper skliper deleted the fix167-error_on_doc_warnings branch January 28, 2021 23:02
chillfig pushed a commit to chillfig/cFS that referenced this pull request Mar 17, 2022
Fix nasa#123, validate input params on TxFile and Playback cmds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main user guide build warnings (and they weren't caught by actions)
2 participants