Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #334, Add Functional Tests Step to CI #350

Conversation

ArielSAdamsNASA
Copy link
Contributor

@ArielSAdamsNASA ArielSAdamsNASA commented Sep 3, 2021

Checklist (Please check before submitting)

Describe the contribution
Fixes #334

Testing performed
Tested on fork repo.
Deprecated Build, Test, and Run: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1198344779
Build, Test, and Run [OMIT_DEPRECATED=true]: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1198344780
Also seen in checks in this PR.

Expected behavior changes
Build, test, and run workflows runs functional tests. Uses cache to reduce build time.

Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal

@skliper
Copy link
Contributor

skliper commented Sep 7, 2021

Looks like 4 jobs that really could be consolidated? Build, make test, then run with the functional test app. Or if these really need to be separate could the build be archived so it doesn't actually need to be built 4 times? Currently may be burning a lot of minutes w/ the duplicated work (especially since this is matrixed).

Copy link
Contributor

@astrogeco astrogeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the separate jobs. We can figure out how to reuse the build files using cache. The one thing i would add is a dependency between run and functional test so that we don't even try to run the functional tests if plain run ./core-cpu doesn't work

.github/workflows/build-cfs-deprecated.yml Outdated Show resolved Hide resolved
.github/workflows/build-cfs.yml Outdated Show resolved Hide resolved
astrogeco added a commit to astrogeco/cFS that referenced this pull request Sep 22, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate September 22, 2021 18:40
@astrogeco astrogeco force-pushed the fix-334-functional-tests-ci branch 2 times, most recently from 1d60ed6 to bf06145 Compare September 22, 2021 18:59
- Combine build-prep and build-cfs jobs
- Rename jobs and artifacts for consistency and clarity
- Update workflow trigger for codeql build
@astrogeco astrogeco merged commit 0965326 into nasa:integration-candidate Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add functional tests step to continuous integration
4 participants