Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

READ_UPLINK command not fully defined #173

Closed
jphickey opened this issue Feb 1, 2024 · 0 comments · Fixed by #174
Closed

READ_UPLINK command not fully defined #173

jphickey opened this issue Feb 1, 2024 · 0 comments · Fixed by #174
Assignees
@jphickey
Labels
enhancement New feature or request

Comments

@jphickey
Copy link
Contributor

jphickey commented Feb 1, 2024

Is your feature request related to a problem? Please describe.
The READ_UPLINK command is not fully integrated as it should be.

Describe the solution you'd like
It needs to be added to EDS, and to follow all the other patterns. Could also help to have a bit more description/documentation on how it works.

Additional context
This command was recently added.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Feb 1, 2024
@jphickey jphickey added the enhancement New feature or request label Feb 1, 2024
@jphickey jphickey mentioned this issue Feb 1, 2024
Merged
dzbaker added a commit that referenced this issue Feb 2, 2024
@dzbaker
Merge pull request #174 from jphickey:fix-173-readuplink
838cb0c 
Fix #173, more complete definition of READ_UPLINK
@dzbaker dzbaker mentioned this issue Feb 2, 2024
Merged
2 tasks
@dzbaker dzbaker closed this as completed in d24fba8 Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #173, more complete definition of READ_UPLINK jphickey/ci_lab
1 participant
@jphickey