-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CFDP PDU introspection features #27
Comments
That chunk of code has been discussed in the past - it is related to some CFDP PDU introspection which seems to be some debug stuff that somehow made it into the framework baseline. IIRC it was agreed on at least one occasion that this should be removed because nobody uses it, nobody tests it, it doesn't have a requirement, and isn't cross-platform compatible. I recommend removing the entire |
Concur. Hijacking this ticket, now more general to address removing CFDP PDU introspection features. |
Taking this ticket because some of this PDU stuff is getting in the way of another change. |
This code has numerous quality issues and has repeatedly been a maintenance problem, and also is of questionable usefulness. It was agreed in the CCB to drop this feature.
This code has numerous quality issues and has repeatedly been a maintenance problem, and also is of questionable usefulness. It was agreed in the CCB to drop this feature.
This code has numerous quality issues and has repeatedly been a maintenance problem, and also is of questionable usefulness. It was agreed in the CCB to drop this feature.
Is your feature request related to a problem? Please describe.
CFDP PDU introspection is old debug code. Remove to simplify ci_lab.
Also subject of recommended issues from lgtm:
ci_lab_app.c
Requester Info
Anh Van, NASA Goddard
The text was updated successfully, but these errors were encountered: