Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CFDP PDU introspection features #27

Closed
avan989 opened this issue Dec 20, 2019 · 3 comments · Fixed by #35 or #38
Closed

Remove CFDP PDU introspection features #27

avan989 opened this issue Dec 20, 2019 · 3 comments · Fixed by #35 or #38
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@avan989
Copy link
Contributor

avan989 commented Dec 20, 2019

Is your feature request related to a problem? Please describe.
CFDP PDU introspection is old debug code. Remove to simplify ci_lab.

Also subject of recommended issues from lgtm:

ci_lab_app.c

line 625 - 732:
Switch has at least one case that is too long: 4 (37 lines)

line 599:

/*    OS_printf("CI: Captured PDU with length = %d\n",PduHdrPtr->PDataLen); */
--
  | This comment appears to contain commented-out code

Requester Info
Anh Van, NASA Goddard

@jphickey
Copy link
Contributor

That chunk of code has been discussed in the past - it is related to some CFDP PDU introspection which seems to be some debug stuff that somehow made it into the framework baseline.

IIRC it was agreed on at least one occasion that this should be removed because nobody uses it, nobody tests it, it doesn't have a requirement, and isn't cross-platform compatible.

I recommend removing the entire CI_ProcessPDU function and all commands associated with the CFDP PDU introspection "feature" of CI LAB.

@skliper
Copy link
Contributor

skliper commented Dec 22, 2019

Concur. Hijacking this ticket, now more general to address removing CFDP PDU introspection features.

@skliper skliper changed the title recommended lgtm issues Remove CFDP PDU introspection features Dec 22, 2019
@skliper skliper added the enhancement New feature or request label Dec 22, 2019
@jphickey jphickey self-assigned this Jan 6, 2020
@jphickey
Copy link
Contributor

jphickey commented Jan 6, 2020

Taking this ticket because some of this PDU stuff is getting in the way of another change.

jphickey added a commit to jphickey/ci_lab that referenced this issue Feb 7, 2020
This code has numerous quality issues and has repeatedly been
a maintenance problem, and also is of questionable usefulness.

It was agreed in the CCB to drop this feature.
jphickey added a commit to jphickey/ci_lab that referenced this issue Feb 7, 2020
jphickey added a commit to jphickey/ci_lab that referenced this issue Feb 7, 2020
This code has numerous quality issues and has repeatedly been
a maintenance problem, and also is of questionable usefulness.

It was agreed in the CCB to drop this feature.
jphickey added a commit to jphickey/ci_lab that referenced this issue Feb 8, 2020
This code has numerous quality issues and has repeatedly been
a maintenance problem, and also is of questionable usefulness.

It was agreed in the CCB to drop this feature.
@astrogeco astrogeco mentioned this issue Mar 10, 2020
@astrogeco astrogeco linked a pull request Mar 10, 2020 that will close this issue
@astrogeco astrogeco added this to the 2.4.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants