Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI_LAB should split message handlers into separate functions #34

Closed
jphickey opened this issue Feb 7, 2020 · 0 comments · Fixed by #35 or #38
Closed

CI_LAB should split message handlers into separate functions #34

jphickey opened this issue Feb 7, 2020 · 0 comments · Fixed by #35 or #38
Assignees
@jphickey
Labels
enhancement New feature or request
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

jphickey commented Feb 7, 2020

Is your feature request related to a problem? Please describe.
The "process ground command" routine in CI_LAB processes some commands "inline". This does not match the current/recommended style which is to put command handling into a separate function.

Describe the solution you'd like
Putting each command into a separate function is the preferred CCB style and it improves modularity of the code.

Additional context
All CFE core apps the sample_app all implement the preferred pattern. CI_LAB should be consistent.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Feb 7, 2020
jphickey added a commit to jphickey/ci_lab that referenced this issue Feb 7, 2020
@jphickey
Fix nasa#34: Follow recommended patterns for message handling
f5e2458 
Make the patterns in CI better match the patterns used
in other modules (CFE core, Sample App, etc)

- Separate each command into a separate handler function
- Each command handler accepts a const pointer to the full message
- Put Telemetry payload into a separate "Payload" sub-structure
- Use naming conventions defined in conventions document

Note the payload name changes only affect the FSW internal
usage, the payload format for the ground system is not changed.
jphickey added a commit to jphickey/ci_lab that referenced this issue Feb 7, 2020
@jphickey
Fix nasa#34: Follow recommended patterns for message handling
5f873e0 
Make the patterns in CI better match the patterns used
in other modules (CFE core, Sample App, etc)

- Separate each command into a separate handler function
- Each command handler accepts a const pointer to the full message
- Put Telemetry payload into a separate "Payload" sub-structure
- Use naming conventions defined in conventions document

Note the payload name changes only affect the FSW internal
usage, the payload format for the ground system is not changed.
@jphickey jphickey mentioned this issue Feb 7, 2020
Merged
jphickey added a commit to jphickey/ci_lab that referenced this issue Feb 8, 2020
@jphickey
Fix nasa#34: Follow recommended patterns for message handling
e1072c0 
Make the patterns in CI better match the patterns used
in other modules (CFE core, Sample App, etc)

- Separate each command into a separate handler function
- Each command handler accepts a const pointer to the full message
- Put Telemetry payload into a separate "Payload" sub-structure
- Use naming conventions defined in conventions document

Note the payload name changes only affect the FSW internal
usage, the payload format for the ground system is not changed.
astrogeco pushed a commit that referenced this issue Mar 9, 2020
@jphickey
Fix #34: Follow recommended patterns for message handling
484412c 
Make the patterns in CI better match the patterns used
in other modules (CFE core, Sample App, etc)

- Separate each command into a separate handler function
- Each command handler accepts a const pointer to the full message
- Put Telemetry payload into a separate "Payload" sub-structure
- Use naming conventions defined in conventions document

Note the payload name changes only affect the FSW internal
usage, the payload format for the ground system is not changed.
@astrogeco astrogeco mentioned this issue Mar 10, 2020
Merged
@astrogeco astrogeco linked a pull request Mar 10, 2020 that will close this issue
IC 20200304 #38
Merged
@astrogeco astrogeco added the enhancement New feature or request label Oct 1, 2020
@astrogeco astrogeco added this to the 2.4.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement New feature or request
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Multiple cleanup items for CI LAB jphickey/ci_lab
IC 20200304 nasa/ci_lab
2 participants
@jphickey @astrogeco