Integration Candidate 2020-03-18 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid port conflicts when having more than one CPU within the same mission load CI_LAB app. Instead of binding to the port directly, add the CPU number as an offset. Subtract 1 so that CPU1 remains at the same port (1234 by default) and cmdUtil is not affected. NOTE: the "cpu number" can be overridden on the command line when using the pc-linux PSP, thereby also permitting the listen point to be tuned for each launch config, if necessary.
Fix #37, Offset the UDP base port per-CPU
astrogeco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #37
Testing performed
See PR #41
Bundle testing in CI, see nasa/cFS#58
Expected behavior changes
See PR, CI_LAB changes its listening port when either using a config with multiple CPUs or using the --cpuid option to override (in pc-linux at least).
System(s) tested on
CI Ubuntu: Bionic
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.
Gerardo E. Cruz-Ortiz, NASA-GSFC