Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forms] Fix select control #114

Merged
merged 1 commit into from
Sep 22, 2015
Merged

[Forms] Fix select control #114

merged 1 commit into from
Sep 22, 2015

Conversation

VWoeltjen
Copy link
Contributor

Use ng-show instead of ng-if to suppress the
'Select One' option after user has chosen something
in a select box; the latter appears to be incompatible
with Angular 1.4.x. #113

Use ng-show instead of ng-if to suppress the
'Select One' option after user has chosen something
in a select box; the latter appears to be incompatible
with Angular 1.4.x. #113
@VWoeltjen VWoeltjen added this to the Ymir milestone Sep 16, 2015
@VWoeltjen
Copy link
Contributor Author

Author Checklist

  1. Changes address original issue? Y
  2. Unit tests included and/or updated with changes? N/A (changes to template only)
  3. Command line build passes? Y
  4. Expect to pass code review? Y

@larkin larkin merged commit acdd35c into master Sep 22, 2015
@larkin
Copy link
Contributor

larkin commented Sep 22, 2015

Review Checklist

  1. Changes appear to address issue? Y
  2. Appropriate unit tests included? Y
  3. Code style and in-line documentation are appropriate? Y
  4. Commit messages meet standards? Y
  5. Project-specific information isolated to appropriate branches? Y

Integration Checklist

  1. Automated build passing after merge? Y
  2. No merge conflicts (or resolution trivial/obvious)? Y
  3. All master branches up-to-date after merge? Y
  4. Project-specific information isolated to appropriate branches? Y

@larkin larkin deleted the open113 branch September 22, 2015 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants