Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set parameter on OS_SelectFdIsSet should be const #1062

Closed
jphickey opened this issue Jun 1, 2021 · 1 comment · Fixed by #1063 or #1076
Closed

Set parameter on OS_SelectFdIsSet should be const #1062

jphickey opened this issue Jun 1, 2021 · 1 comment · Fixed by #1063 or #1076
Assignees
Milestone

Comments

@jphickey
Copy link
Contributor

jphickey commented Jun 1, 2021

Is your feature request related to a problem? Please describe.
This function only checks bits (read only), it does not modify the "Set" argument

Describe the solution you'd like
The pointer should be qualified const

Additional context
#854 (part of CFS-38 review) corrected the internal function, but it looks like this one was missed.
It is part of the public API but adding const here shouldn't break anything.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Jun 1, 2021
@jphickey
Copy link
Contributor Author

jphickey commented Jun 1, 2021

Note: prototype to correct is here:

bool OS_SelectFdIsSet(OS_FdSet *Set, osal_id_t objid);

jphickey added a commit to jphickey/osal that referenced this issue Jun 1, 2021
This function does not modify its "Set" argument, therefore
it should be qualified as "const".
astrogeco added a commit that referenced this issue Jun 10, 2021
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants